chore(be): fix checkstyle violations - #2297
Merged
Merged
Conversation
paulushcgcj
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets Checkstyle compliance in the legacy module by adjusting test code formatting/signatures and cleaning up Javadoc formatting.
Changes:
- Removed an unnecessary
throws JsonProcessingExceptionfrom a parameterized test method. - Updated integration test DOB construction to use
java.time.Month(and reformatted oneArguments.ofblock). - Adjusted Javadoc
@returntags to avoid invalid generic{@link ...}usage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| legacy/src/test/java/ca/bc/gov/app/util/PatchUtilsTest.java | Removes redundant checked-exception declaration from a parameterized test method. |
| legacy/src/test/java/ca/bc/gov/app/service/ClientSearchIndividualServiceIntegrationTest.java | Uses Month enum for LocalDate creation and reformats one argument set. |
| legacy/src/main/java/ca/bc/gov/app/service/patch/PatchOperationContactEditService.java | Minor whitespace adjustment near method boundary (currently introduces trailing whitespace). |
| legacy/src/main/java/ca/bc/gov/app/service/ClientContactService.java | Updates Javadoc @return links to be Checkstyle/Javadoc-friendly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| .then(); | ||
| } | ||
|
|
Contributor
|
mamartinezmejia
enabled auto-merge (squash)
June 25, 2026 18:08
mamartinezmejia
disabled auto-merge
June 26, 2026 17:32
mamartinezmejia
enabled auto-merge (squash)
June 26, 2026 17:32
mamartinezmejia
disabled auto-merge
June 26, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: