fix: only create establishment order bucket for admin app - #1316
Merged
Conversation
marcellmueller
force-pushed
the
fix/establishment-order-bucket
branch
from
October 17, 2025 21:21
1e1824a to
f24b5b2
Compare
fbarreta
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I merged the s3 bucket update I realized it was failing in the public app as it was trying to create the same bucket (both apps use the same infrastructure setup). This makes it so the public app doesn't create the bucket as it's not needed.
Tested that both deploy now here:
https://github.com/bcgov/nr-rec-resources/actions/runs/18604924799/job/53052614616