feat(#977): add tenure map improvements - #1007
Merged
Merged
Conversation
Expanded the 'red' color array in colorMap to include a broader range of shades for improved map layer styling. Removed unnecessary comment from fillColor assignment.
3 tasks
Introduced getPropertyName method to select property names based on the 'kind' parameter. This allows for additional properties to be requested for specific map layers, improving flexibility in data retrieval.
Introduces a new integration test to verify successful retrieval of cut block polygon and its properties from OpenMapsService. Adds corresponding test data to TestConstants for use in the test.
Introduces handling for WHSE_FOREST_TENURE.FTEN_CUT_BLOCK_POLY_SVW in OpeningsMapEntryPopup, displaying cut block details. Updates MapLayer popup properties to use consistent keys and include cutting permit ID.
Abradat
marked this pull request as ready for review
August 22, 2025 19:27
Abradat
requested review from
carolinemwood,
craigyu and
paulushcgcj
as code owners
August 22, 2025 19:27
…iceIntegrationTest Corrects the order of PROPERTYNAME query parameter and updates the test to use the correct layer name in getOpeningPolygonAndProperties. Ensures test accuracy and alignment with expected API behavior.
Changed the PROPERTYNAME query parameter value from 'GEOMETRY,OPENING_ID' to 'OPENING_ID,GEOMETRY' in OpeningMapsEndpointIntegrationTest to match expected API behavior.
craigyu
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change implements the map improvements for the tenure identification tab.
Fixes #977
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: