feat: #999 create opening step 2 3 frontend scaffolding - #1013
Merged
craigyu merged 15 commits intoSep 12, 2025
Conversation
craigyu
marked this pull request as ready for review
September 11, 2025 16:05
craigyu
requested review from
Abradat,
carolinemwood and
paulushcgcj
as code owners
September 11, 2025 16:05
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements frontend scaffolding for steps 2 and 3 of the opening creation process, building upon the file upload functionality from step 1. It establishes the data form structure with validation and review capabilities.
- Adds comprehensive form handling with input validation for opening details (org unit, category, gross area, etc.)
- Implements tenure information management with add/edit/delete capabilities and primary license selection
- Creates a review & create step with cancel confirmation modal and form validation
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/utils/ValidationUtils.ts |
Adds numeric validation utility function |
frontend/src/utils/InputUtils.ts |
Updates scrollToSection to handle optional ID parameter |
frontend/src/types/FormInputType.ts |
Defines generic form input type for validation state |
frontend/src/styles/theme.scss |
Removes unused grid imports |
frontend/src/styles/default-components.scss |
Adds new CSS classes for form styling |
frontend/src/services/OpenApi/services/CodesEndpointService.ts |
Updates API endpoint URL for opening categories |
frontend/src/services/OpenApi/models/* |
Fixes duplicate type unions in model definitions |
frontend/src/screens/CreateOpening/* |
Major refactor to use structured form state and implement multi-step validation |
frontend/src/components/CreateOpeningSteps/* |
Implements DataForm component with tenure management and form validation |
frontend/src/components/MapPreview/index.tsx |
Makes geojson prop optional and adds null check |
| Test files | Updates tests to reflect API endpoint changes and model updates |
backend/src/main/java/ca/bc/gov/restapi/results/oracle/endpoint/CodesEndpoint.java |
Updates endpoint path from /categories to /opening-categories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
craigyu
enabled auto-merge (squash)
September 12, 2025 16:45
craigyu
deleted the
feat/999-create-opening-step-2-3-frontend-scaffolding
branch
September 12, 2025 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #999
Needs to log in with an account with forest client(s) assigned on FAM.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: