Skip to content

feat: #999 create opening step 2 3 frontend scaffolding - #1013

Merged
craigyu merged 15 commits into
mainfrom
feat/999-create-opening-step-2-3-frontend-scaffolding
Sep 12, 2025
Merged

feat: #999 create opening step 2 3 frontend scaffolding#1013
craigyu merged 15 commits into
mainfrom
feat/999-create-opening-step-2-3-frontend-scaffolding

Conversation

@craigyu

@craigyu craigyu commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

Description

Implements #999

Needs to log in with an account with forest client(s) assigned on FAM.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@craigyu craigyu linked an issue Sep 9, 2025 that may be closed by this pull request
@craigyu craigyu self-assigned this Sep 11, 2025
@craigyu
craigyu marked this pull request as ready for review September 11, 2025 16:05
@craigyu craigyu changed the title Feat/999 create opening step 2 3 frontend scaffolding feat: #999 create opening step 2 3 frontend scaffolding Sep 11, 2025
@Abradat
Abradat requested a review from Copilot September 11, 2025 19:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements frontend scaffolding for steps 2 and 3 of the opening creation process, building upon the file upload functionality from step 1. It establishes the data form structure with validation and review capabilities.

  • Adds comprehensive form handling with input validation for opening details (org unit, category, gross area, etc.)
  • Implements tenure information management with add/edit/delete capabilities and primary license selection
  • Creates a review & create step with cancel confirmation modal and form validation

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
frontend/src/utils/ValidationUtils.ts Adds numeric validation utility function
frontend/src/utils/InputUtils.ts Updates scrollToSection to handle optional ID parameter
frontend/src/types/FormInputType.ts Defines generic form input type for validation state
frontend/src/styles/theme.scss Removes unused grid imports
frontend/src/styles/default-components.scss Adds new CSS classes for form styling
frontend/src/services/OpenApi/services/CodesEndpointService.ts Updates API endpoint URL for opening categories
frontend/src/services/OpenApi/models/* Fixes duplicate type unions in model definitions
frontend/src/screens/CreateOpening/* Major refactor to use structured form state and implement multi-step validation
frontend/src/components/CreateOpeningSteps/* Implements DataForm component with tenure management and form validation
frontend/src/components/MapPreview/index.tsx Makes geojson prop optional and adds null check
Test files Updates tests to reflect API endpoint changes and model updates
backend/src/main/java/ca/bc/gov/restapi/results/oracle/endpoint/CodesEndpoint.java Updates endpoint path from /categories to /opening-categories

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread frontend/src/screens/CreateOpening/constants.ts Outdated
Comment thread frontend/src/components/CreateOpeningSteps/DataForm/index.tsx

@Abradat Abradat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM! 🚀

@craigyu
craigyu enabled auto-merge (squash) September 12, 2025 16:45
@craigyu
craigyu merged commit 8086cd7 into main Sep 12, 2025
29 of 31 checks passed
@craigyu
craigyu deleted the feat/999-create-opening-step-2-3-frontend-scaffolding branch September 12, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Opening Step 2 & 3 Frontend Scaffolding

3 participants