feat: #962 create opening step 1 scaffolding - #997
Merged
Conversation
…-create-opening-step-1-scaffolding
craigyu
requested review from
Abradat,
carolinemwood and
paulushcgcj
as code owners
August 19, 2025 01:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the initial scaffolding for the opening creation workflow (step 1) in the Silva application. It introduces a file upload interface that allows users to upload spatial geometry files (GeoJSON, GML, XML/ESF) and displays a preview of the uploaded geometry on a map.
Key changes include:
- Implemented spatial file parsing utilities for multiple geospatial formats with coordinate system transformations
- Created a multi-step wizard interface with progress indicator for opening creation
- Added file upload functionality with validation and map preview capabilities
Reviewed Changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/utils/SpatialUtils.ts | Core spatial processing utilities for parsing GML, ESF, and GeoJSON files with coordinate transformations |
| frontend/src/screens/CreateOpening/index.tsx | Main component implementing the multi-step opening creation workflow |
| frontend/src/components/CreateOpeningSteps/FileUpload/index.tsx | File upload component with validation and spatial file processing |
| frontend/src/components/MapPreview/index.tsx | Map component for displaying uploaded geometry using Leaflet |
| frontend/package.json | Added dependencies for spatial processing (OpenLayers, proj4) |
| frontend/src/utils/InputUtils.ts | Added scroll utility function |
| frontend/src/utils/ForestClientUtils.ts | Added client formatting utility |
| frontend/src/types/OpeningTypes.ts | Added opening type definitions |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…github.com/bcgov/nr-silva into feat/962-create-opening-step-1-scaffolding
craigyu
enabled auto-merge (squash)
August 19, 2025 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes #962
Allows user to upload a file and display a preview...
The text in some areas are modified from the design by me, I will discuss this with the team before this is merged.
For the
formstate inscreens/CreateOpening, I was thinking about using a context provider but decided not to since likely only 2 components will be using it.How to test
3 test files are added to
frontend/src/__test__/fixturesThanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: