Skip to content

ORV2-4908: Record account user add and removes in the holder account history#2266

Merged
praju-aot merged 4 commits intomainfrom
ORV2-4908
Apr 8, 2026
Merged

ORV2-4908: Record account user add and removes in the holder account history#2266
praju-aot merged 4 commits intomainfrom
ORV2-4908

Conversation

@praju-aot
Copy link
Copy Markdown
Collaborator

@praju-aot praju-aot commented Apr 8, 2026

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Update addOrActivateCreditAccountUser and deactivateCreditAccountUser to record user add/remove account activity.

  • Update ORBC_CREDIT_ACCOUNT_ACTIVITY_TYPE reference data to add new activity types for credit account user management

    • USERADDED
    • USERRMVD
  • Modify [tps].[CopyMigratedCreditAccounts] stored procedure to log user additions and removals as part of TPS migration'

Fixes # (issue)
https://moti-imb.atlassian.net/browse/ORV2-4908

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run test
  • npm run test:e2e

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

…istory

- Update addOrActivateCreditAccountUser and deactivateCreditAccountUser to record user add/remove account activity.

- Update ORBC_CREDIT_ACCOUNT_ACTIVITY_TYPE reference data to add new activity types for credit account user management
  - USERADDED
  - USERRMVD
-  Modify [tps].[CopyMigratedCreditAccounts] stored procedure to log user additions and removals as part of TPS migration'
Replace || with + for concatenation
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
4.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@praju-aot praju-aot merged commit 837c79c into main Apr 8, 2026
28 of 29 checks passed
@praju-aot praju-aot deleted the ORV2-4908 branch April 8, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants