Kbdev 1524 signed license - #126
Merged
Merged
Conversation
KBDEV-1524
KBDEV-1524 routes are not case sensitive so remove duplicates
KBDEV-1524
kttkjl
previously approved these changes
May 7, 2026
kttkjl
left a comment
kttkjl
left a comment
Member
There was a problem hiding this comment.
Looks good, just some questions
| fixed = fixed.replace(/<div[^>]*aria-relevant="additions text"[^>\/]*(>[^/]*<\/div>|\/>)/, ''); | ||
| // other generated ag-grid ids | ||
| fixed = fixed.replace(/id="cell-[^-"]+-[^-"]+"/, (matched) => matched.replaceAll(/\d+/g, 'XXXX')); | ||
| fixed = fixed.replace(/id="ag-\d+/, 'id="ag-XXXX'); |
Member
There was a problem hiding this comment.
do we need /g in these? or is the first match good enough?
Collaborator
Author
There was a problem hiding this comment.
doesn't seem to make a difference but should have them regardless 3a10ae6
| "commit": "git-cz", | ||
| "storybook": "TZ=UTC storybook dev -p 6006", | ||
| "build-storybook": "TZ=UTC storybook build" | ||
| "storybook": "REACT_APP_VERSION=1.0.0 TZ=UTC storybook dev -p 6006", |
Member
There was a problem hiding this comment.
should we make this dynamic, or is this = a default already?
Collaborator
Author
There was a problem hiding this comment.
this is to make it not dynamic for the tests
remove flaky ag-grid class ensure dom order and suppress virtualization when testing replace more relative dates
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
+ Coverage 59.46% 66.09% +6.62%
===========================================
Files 120 120
Lines 4557 4595 +38
Branches 1545 1544 -1
===========================================
+ Hits 2710 3037 +327
+ Misses 1577 1327 -250
+ Partials 270 231 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnguyen-bcgsc
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bulk of the changes are adding stories for more of the views and updating react-router (which changed the package name and therefore affected a ton of imports)