Kbdev 1488 no nav on error - #127
Merged
Merged
Conversation
bnguyen-bcgsc
previously approved these changes
May 1, 2026
areisle
force-pushed
the
KBDEV-1488-no-nav-on-error
branch
from
May 7, 2026 21:33
565fcd2 to
654f705
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #127 +/- ##
===========================================
+ Coverage 66.09% 75.41% +9.31%
===========================================
Files 120 120
Lines 4595 4551 -44
Branches 1544 1526 -18
===========================================
+ Hits 3037 3432 +395
+ Misses 1327 947 -380
+ Partials 231 172 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KBDEV-1488
KBDEV-1488 fix missing aria labels don't error on no nodes
KBDEV-1488
KBDEV-1488
KBDEV-1488 show error either as alert on page or use snackbar for pages where data is necessary to render page in any meaningful way, throw error to boundary
areisle
force-pushed
the
KBDEV-1488-no-nav-on-error
branch
from
May 11, 2026 17:22
654f705 to
2bf87c4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bnguyen-bcgsc
self-requested a review
May 11, 2026 19:35
bnguyen-bcgsc
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see ticket for example of new error display
this changes to no longer navigate to an /error page when an error occurs. instead, errors from mutations are shown inline, errors loading a page use the error boundary (so the url doesn't change but it looks the same as the previous /error page did), and other errors use a snackbar