Page-align offset before calculating virtual addresses for ELF by andrewjcg · Pull Request #626 · benfred/py-spy

andrewjcg · 2023-10-26T18:01:03Z

This mimics what ld.so does by aligning the virtual addresses to the current page size, and fixes:

Existing issues with DSOs produced by LLD which, unlike gold or BFD, doesn't align p_vaddr to p_align (the previous overflow prevention wasn't sufficient here).
Systems w/ configurable page sizes, where just using p_align isn't enough.

This fixes a bug where we were calculating incorrect address offsets.

andrewjcg force-pushed the page_align branch from d1c5469 to 016cafe Compare November 9, 2023 03:40

andrewjcg force-pushed the page_align branch from fa9cf8f to af4df81 Compare November 1, 2024 23:00

Align virtual address base

c317de7

This fixes a bug where we were calculating incorrect address offsets.

andrewjcg force-pushed the page_align branch from af4df81 to c317de7 Compare November 1, 2024 23:01

benfred reviewed Nov 1, 2024

View reviewed changes

Comment thread src/binary_parser.rs Outdated

technicianted mentioned this pull request Mar 31, 2025

Fix issue with elf vaddr page alignment benfred/remoteprocess#100

Merged

benfred added 2 commits July 12, 2025 13:34

Update src/binary_parser.rs

02bae44

Merge branch 'master' into page_align

50b6b61

benfred approved these changes Jul 31, 2025

View reviewed changes

benfred added the bug Something isn't working label Jul 31, 2025

benfred merged commit a3858df into benfred:master Jul 31, 2025
74 checks passed

Provide feedback