Skip to content

Do not fail sampling completely if a single thread dies before sampling #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfred merged 2 commits into from
Jul 13, 2025
Merged

Do not fail sampling completely if a single thread dies before sampling #771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c55e2e
Do not fail sampling completely if a single thread died before readin…
I-Al-Istannen Jun 25, 2025
ee5b6d2
Merge branch 'master' into fix/do-not-give-up-on-process
benfred Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/python_spy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,12 @@ impl PythonSpy {
} else {
for thread in self.process.threads()?.iter() {
let threadid: Tid = thread.id()?;
thread_activity.insert(threadid, thread.active()?);
let Ok(active) = thread.active() else {
// Do not fail all sampling if a single thread died between entering the loop
// and reading its status.
continue;
};
thread_activity.insert(threadid, active);
}
}

Expand Down
Loading