Skip to content

Add consensuswarn to CI pipeline#2462

Open
crStiv wants to merge 2 commits intoberachain:mainfrom
crStiv:issue-833
Open

Add consensuswarn to CI pipeline#2462
crStiv wants to merge 2 commits intoberachain:mainfrom
crStiv:issue-833

Conversation

@crStiv
Copy link
Copy Markdown

@crStiv crStiv commented Feb 3, 2025

Closes #833

Changes:

  • Added consensuswarn to CI matrix
  • Created consensuswarn target in Makefile
  • Integrated consensuswarn into the linter suite

The tool will run as part of the standard CI checks to help maintain code quality and prevent consensus-related bugs early in development.

Signed-off-by: crStiv <cryptostiv7@gmail.com>
Signed-off-by: crStiv <cryptostiv7@gmail.com>
@crStiv crStiv requested a review from a team as a code owner February 3, 2025 00:18
@rezzmah
Copy link
Copy Markdown
Contributor

rezzmah commented Feb 3, 2025

https://github.com/orijtech/consensuswarn
Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

@abi87
Copy link
Copy Markdown
Contributor

abi87 commented Feb 3, 2025

https://github.com/orijtech/consensuswarn Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

This is related to #833 which is marked goodFirstIssue so it's a fair attempt at contributing. I like the idea of the tool, but it's probably an overkill for us? We should discuss this.
Definitely this PR does not do all the job though: I believe we have to mark the proper functions to be warned about

@calbera calbera added the os-review Open source contribution to review label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os-review Open source contribution to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ci): Investigating using https://github.com/orijtech/consensuswarn

4 participants