Skip to content

chore(forks): Enforce Fork Ordering #2790

Merged
rezzmah merged 2 commits intomainfrom
add-fork-timestamp-ordering-enforcement
May 28, 2025
Merged

chore(forks): Enforce Fork Ordering #2790
rezzmah merged 2 commits intomainfrom
add-fork-timestamp-ordering-enforcement

Conversation

@rezzmah
Copy link
Copy Markdown
Contributor

@rezzmah rezzmah commented May 28, 2025

As discussed here #2777 (comment)

Just like Geth, we should enforce fork ordering.

@rezzmah rezzmah requested a review from a team as a code owner May 28, 2025 00:10
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (2cae77f) to head (cbe19d3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   60.66%   60.66%   -0.01%     
==========================================
  Files         348      348              
  Lines       16067    16081      +14     
  Branches       22       22              
==========================================
+ Hits         9747     9755       +8     
- Misses       5576     5581       +5     
- Partials      744      745       +1     
Files with missing lines Coverage Δ
chain/spec.go 74.78% <100.00%> (+3.36%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@rezzmah rezzmah merged commit b1882a3 into main May 28, 2025
19 checks passed
@rezzmah rezzmah deleted the add-fork-timestamp-ordering-enforcement branch May 28, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants