chore(preconf): enrich sequencer server health check impl.#3086
Open
bar-bera wants to merge 6 commits intopreconf-devfrom
Open
chore(preconf): enrich sequencer server health check impl.#3086bar-bera wants to merge 6 commits intopreconf-devfrom
bar-bera wants to merge 6 commits intopreconf-devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enriches the sequencer preconf server /eth/v1/preconf/health endpoint by reporting readiness/sync state and execution-layer connectivity, wiring in existing node services to drive those checks.
Changes:
- Extend
preconf.Serverto acceptSyncCheckerandELCheckerdependencies and use them in the health handler to return 200 vs 503 plus a JSON body. - Wire
ConsensusServiceandEngineClientinto the sequencer preconf server provider. - Add
HealthResponsetype and new unit tests covering the health endpoint status/flags.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| node-core/components/preconf_server.go | Injects consensus + engine clients into the preconf server so health checks can reflect node/EL state. |
| beacon/preconf/types.go | Adds HealthResponse struct returned by /eth/v1/preconf/health. |
| beacon/preconf/server.go | Implements health response building and 200/503 logic based on readiness, syncing, and EL connectivity. |
| beacon/preconf/server_test.go | Updates server construction for new deps and adds coverage for the health endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## preconf-dev #3086 +/- ##
===============================================
+ Coverage 58.93% 59.34% +0.40%
===============================================
Files 379 379
Lines 19531 19558 +27
===============================================
+ Hits 11511 11606 +95
+ Misses 7058 6987 -71
- Partials 962 965 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses existent services to add checks on the
/eth/v1/preconf/healthendpoint of the sequencer server: