Translation package - #100
Open
melijimenez11 wants to merge 1845 commits into
Open
Conversation
add: TierGrid and necessary changes
…her not responding
Collaborator
Author
|
Hi @fantauzza I noticed the paragraph on Was aligning this paragraph to the nav's left edge a firm design requirement? If so, do you have a preferred way to set an initial value for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements i18n migration - next-intl integration for
apps/mainWhat changed
next-intlat the monorepo root (available to all apps) and restructuredapps/mainroutes underapp/[locale]/messages/en.jsonandmessages/es.jsonwith a few of the homepage strings (only video hero and about panel have been tested thus far. Refer to those when you're testing)packages/i18n/src/RichTextComponent.tsx- a centralized rich text tag system (<bold>,<italic>,<p>,<br>) for use witht.rich()across all appsaccentItalictypography variant to the shared theme (Merriweather italic, inherits parent font size)LanguageSwitcherinHeader.tsxwith client-side locale detection viaLocaleDetectorswitchLocaleutility inapp/lib/for hard navigation between locales (required for static export)app/layout.tsxto be a pass-through shell -<html>and<body>now owned by[locale]/layout.tsxoutput: "export")AboutCtaLinkto usecomponent="span"onTypography subtitle1TranslationProvideranduseTranslationexports inpackages/i18n- still exported forstoryline-flowandstoryline-climatewhich have not been migrated yetHow to test
localhost:[port]/en- verify homepage renders in English/eswith Spanish content/es- verify it stays in Spanish/- verify redirect to/esKnown issues not introduced by this PR
EquityPanel.tsxhas a pre-existing type error (Type 'undefined' cannot be used as an index type) that fails the build. This exists ondevas well.scenarioExplorer,map, andvizpackages - not introduced by this branch.VideoHeroshifts width slightly after page load. This is caused by--coeqwal-nav-leftbeing set after hydration. The shift was pre-existing but became more noticeable after addingshowLanguageSwitchertoHeader.tsx- see inline comment on that line.Notes
TranslationProvideris intentionally kept inpackages/i18n- do not remove untilstoryline-flowandstoryline-climateare migratedEquityPanel.tsxbuild error needs to be fixed separately before this branch can fully pass CIfontWeight: ....