Added ability to use different input types - #544
Open
damisul wants to merge 3 commits into
Open
Conversation
…x_wait_time instead' in test_helpers
…y. Fixed them by creating application.css and including it in application.html.erb instead of separate css files
Author
|
Also there were rspec failures in rails-4.2 enviroment. If I understand correctly, they were caused by sprocked v3.0 |
|
I wonder why this havn't been merged yet, also duplicate of #551 |
|
This would be very helpful. Anything we can do to get this moved forward? |
thejandroman
pushed a commit
to thejandroman/best_in_place
that referenced
this pull request
Jan 15, 2019
thejandroman
pushed a commit
to thejandroman/best_in_place
that referenced
this pull request
Jan 15, 2019
|
Thanks this post helped me a lot and i made the changes in my best_in_place.js file according to your commit and my code is successfully working 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML5 introduced new handy input types like number, url, etc. and some basic validations.
I've tried to pass additional options to bip_helper in html_attrs params like
I've checked sources and see that input editor assumes that input always has 'text' type.
I've modified javascript to allow other input types.
now it works for me