fix(to-response): preserve multiple Set-Cookie when merging headers#137
Merged
Conversation
bytaesu
commented
Apr 29, 2026
Member
- Replaces Fix #118 - toResponse overwrites multiple Set-Cookie headers #119
- Closes toResponse overwrites multiple Set-Cookie headers #118
Co-authored-by: Rastislav ₡ore <rastislav@onion.email>
commit: |
There was a problem hiding this comment.
Pull request overview
Fixes toResponse() header merging so that multiple Set-Cookie headers are preserved (instead of being overwritten) when building/merging Response objects, addressing issue #118.
Changes:
- Add a
copyHeaders()helper thatappend()sSet-Cookiewhileset()ing all other headers. - Update
toResponse()header merge points (existingResponsebranch and_flag: "json"branch) to usecopyHeaders(). - Add tests covering multi-
Set-Cookiepreservation across the relevant merge scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/better-call/src/to-response.ts | Introduces copyHeaders() and updates merge logic to preserve multiple Set-Cookie values. |
| packages/better-call/src/to-response.test.ts | Adds a dedicated test block validating multi-Set-Cookie preservation and router header propagation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Successfully created backport PR for |
bytaesu
added a commit
that referenced
this pull request
Apr 29, 2026
Contributor
|
@bytaesu Can we produce release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.