fix(Selection): bind drag listeners to the container's ownerDocument#2810
Open
gagehohwart wants to merge 1 commit into
Open
fix(Selection): bind drag listeners to the container's ownerDocument#2810gagehohwart wants to merge 1 commit into
gagehohwart wants to merge 1 commit into
Conversation
Selection attaches its mouse/drag listeners and runs element hit-testing against the module-global `document`/`window`. When the calendar is rendered into a different document (a React portal into a separate `window.open` window or an iframe), those listeners are bound to the wrong document and never receive the events fired in the calendar's actual window. Event move/resize and drag-from-outside silently stop working (ordinary clicks keep working because React delegates synthetic events correctly). Resolve the owning document/window from the container node's `ownerDocument` and attach all listeners and measurements there. For the normal in-page calendar this resolves to the global document/window, so behavior is unchanged. Closes bigcalendar#2809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2809
Selection attaches its mouse/drag listeners and runs element hit-testing against the module-global
document/window. When the calendar is rendered into a different document (a React portal into a separatewindow.openwindow or an iframe), those listeners are bound to the wrong document and never receive the events fired in the calendar's actual window. Event move/resize and drag-from-outside silently stop working (ordinary clicks keep working because React delegates synthetic events correctly).Resolve the owning document/window from the container node's
ownerDocumentand attach all listeners and measurements there. For the normal in-page calendar this resolves to the global document/window, so behavior is unchanged.