Only show the impound update action for the org's own record - #4006
Merged
Conversation
The org-admin top actions rendered the impound update panel for any impounded bike, so a staff member at an impound_bikes org viewing a bike impounded by someone else got a form pointing into their own org's routes. An unorganized impound record has no display_id, so building that URL raised UrlGenerationError and 500'd the registration page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The impound update guard changed markup inside the cached fragment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
Screenshots/rails/view_components/registrations/show/org_top_actions/wrapper/component/default?panel=impound_updateThe preview's impounded bike now carries an impound record, so the update panel renders. On
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A staff member at an
impound_bikesorg viewing an impounded bike got the Update Impound Record action no matter who impounded it — the form then pointed into their org's impound routes, which the record isn't in. An unorganized impound record has a nildisplay_idby design, soorganization_impound_record_pathcouldn't build a URL at all and the registration page 500'd (133103079).current_impound_record.organization_idto match the viewing org. Another org's record silently pointed at a display_id the org'sfriendly_find!would 404 on, so that case was broken too, just more quietly.