Require the address on register step 2 for orgs that ask for it - #4009
Merged
Conversation
`UI::Forms::AddressGroup` takes `required:` and `street_2:`, and step 2 passes `required:` from the organization's `require_reg_address`, the way it already gates `student_id` on `require_reg_student_id`. - Everything but street_2 gets the required attribute and a starred label. - Only the showing half of the state/region pair is required — the browser won't submit a form holding a hidden required field, and can't focus it to say why — so the Stimulus controller moves `required` across when the country changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AddressGroup renders inside the wrapper's fragment cache, so its markup change moves the digest. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI::Forms::AddressGrouptakesrequired:andstreet_2:, and register step 2 passesrequired:from the organization'srequire_reg_address— the way it already gatesstudent_idonrequire_reg_student_id.requiredacross when the country changes.UI::Forms::Select/UI::Forms::Inputrather than hand-rolledtwinputmarkup.