Add fix for generating embeddings#18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the embedding export functionality by ensuring that embeddings are correctly included in CSV exports when requested, and adds comprehensive test coverage for this behavior. The changes also improve the reliability of the export process and update related tests to check for the correct function calls and output.
Embedding Export Improvements:
export_embeddings_to_csvfunction inembedding_generation_utils.pynow includes embeddings in the export wheninclude_embeddings=Trueis specified, by passing the appropriate argument to the store'sfindmethod.generate_embeddingsfunction now always setsinclude_embeddings=Truewhen exporting embeddings, ensuring that the exported CSV contains embedding data.Testing Enhancements:
test_cli_embeddings.pynow asserts thatexport_embeddings_to_csvis called withinclude_embeddings=True, verifying the correct function call signature.test_embedding_generation.pyverifies that embeddings are included in the CSV output when requested, and that the output has the expected format and content.