Skip to content

Add fix for generating embeddings#18

Merged
caufieldjh merged 1 commit into
mainfrom
embedding_repairs_20260508
May 8, 2026
Merged

Add fix for generating embeddings#18
caufieldjh merged 1 commit into
mainfrom
embedding_repairs_20260508

Conversation

@caufieldjh

Copy link
Copy Markdown
Contributor

This pull request enhances the embedding export functionality by ensuring that embeddings are correctly included in CSV exports when requested, and adds comprehensive test coverage for this behavior. The changes also improve the reliability of the export process and update related tests to check for the correct function calls and output.

Embedding Export Improvements:

  • The export_embeddings_to_csv function in embedding_generation_utils.py now includes embeddings in the export when include_embeddings=True is specified, by passing the appropriate argument to the store's find method.
  • The CLI's generate_embeddings function now always sets include_embeddings=True when exporting embeddings, ensuring that the exported CSV contains embedding data.

Testing Enhancements:

  • The test for CLI embedding export in test_cli_embeddings.py now asserts that export_embeddings_to_csv is called with include_embeddings=True, verifying the correct function call signature.
  • A new test in test_embedding_generation.py verifies that embeddings are included in the CSV output when requested, and that the output has the expected format and content.

@caufieldjh caufieldjh merged commit 33f7949 into main May 8, 2026
2 checks passed
@caufieldjh caufieldjh deleted the embedding_repairs_20260508 branch May 8, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant