Add model parameter for generating embeddings#19
Merged
caufieldjh merged 2 commits intoMay 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the embeddings generation pipeline to support selecting any CurateGPT embedding model, including OpenAI and Hugging Face models, via a new
--modelparameter. The changes clarify when theOPENAI_API_KEYis required, improve help/documentation, and add comprehensive tests for the new behavior.Major CLI and API improvements:
--model(-m) option to thegenerate-embeddingscommand, allowing users to specify the CurateGPT embedding model (e.g.,openai:text-embedding-3-smallor a Hugging Face model). The code now only requiresOPENAI_API_KEYif an OpenAI model is selected, and passes the model parameter through all layers to CurateGPT. [1] [2] [3] [4] [5] [6] [7]Documentation updates:
README.mdto reflect the new model selection option, clarify requirements forOPENAI_API_KEY, and improve cost explanations. Added usage examples for specifying a model. [1] [2] [3]Testing improvements:
OPENAI_API_KEYfor OpenAI models.These changes make the embeddings pipeline more flexible, user-friendly, and robust for both OpenAI and non-OpenAI embedding models.