Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 97.70% 98.50% +0.79%
==========================================
Files 46 46
Lines 13790 13948 +158
==========================================
+ Hits 13474 13739 +265
+ Misses 316 209 -107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
307d025 to
9a9fbb4
Compare
b70182e to
b77fb17
Compare
b97c522 to
c923836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the previous work from #586 and #585.
The changeset is gigantic, but the overwhelming majority of it is adding new tests, as well as moving tests across different test files when they become too large for compilation.
There are no API changes, and the relevant changes are all internal to the parser.
The PR address many existing YAML issues, notably:
,: