Conversation
cthoyt
changed the title
pyobo.get_name() by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the functionality of
pyobo.get_name()(and related getters) in the case when there's an alternate ID. Before, it always upgraded the ID. Now, there are three possibilities:upgrade_identifier=None) it will only upgrade the identifier if the field is missing from the base mapI found an example in CHMO with
CHMO:0000067microscopy andCHMO:0000005(chrono-amperometry) whereCHMO:0000005's label was getting remapped to microscopy. This isn't the right thing to do unless the label was removed when the term was deprecated.