Fixing mac issues - #40
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens performance tracking on macOS by adding fallbacks for memory accounting and handling unsupported semaphore introspection, so the inference performance tracker can run without crashing on macOS.
Changes:
- Add a fallback from
memory_full_info().usstomemory_info().rsswhen access is denied (including for child processes). - Catch
NotImplementedErrorfromSemaphore.get_value()to avoid macOS runtime failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
stefantaubert
approved these changes
May 9, 2026
stefantaubert
added a commit
that referenced
this pull request
May 9, 2026
* Fix issue 32 (#35) * fix table * fix issue 32 * rm accident * bump version * Fixing mac issues (#40) * Fixing mac issues * fix issue --------- Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * Upcast timing columns to float32 in Arrow export to avoid halffloat interop issues (#43) * add fix for issue 38 * add comment for current limitation --------- Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> --------- Co-authored-by: Josef Haupt <josef_haupt@gmx.net> Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Felix Günther <guenther@oekofor.de>
stefantaubert
added a commit
that referenced
this pull request
May 9, 2026
* Fix issue 32 (#35) * fix table * fix issue 32 * rm accident * bump version * Fixing mac issues (#40) * Fixing mac issues * fix issue --------- Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * Upcast timing columns to float32 in Arrow export to avoid halffloat interop issues (#43) * Upcast timing columns to float32 in Arrow export to avoid halffloat interop issues * add fix for issue 38 * add comment for current limitation --------- Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * Add option to set birdnet app data manually (#37) * Add option to set birdnet app data manually * update with copilot suggestions * add entry in changelog --------- Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * bump version --------- Co-authored-by: Josef Haupt <josef_haupt@gmx.net> Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Felix Günther <guenther@oekofor.de>
stefantaubert
added a commit
that referenced
this pull request
May 9, 2026
* Fix issue 32 (#35) * fix table * fix issue 32 * rm accident * bump version * Fixing mac issues (#40) * Fixing mac issues * fix issue --------- Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * Upcast timing columns to float32 in Arrow export to avoid halffloat interop issues (#43) * Upcast timing columns to float32 in Arrow export to avoid halffloat interop issues * add fix for issue 38 * add comment for current limitation --------- Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * Add option to set birdnet app data manually (#37) * Add option to set birdnet app data manually * update with copilot suggestions * add entry in changelog --------- Co-authored-by: Stefan Taubert <23339395+stefantaubert@users.noreply.github.com> * bump version --------- Co-authored-by: Josef Haupt <josef_haupt@gmx.net> Co-authored-by: Stefan Kahl <kahst@hrz.tu-chemnitz.de> Co-authored-by: Felix Günther <guenther@oekofor.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.