[Prototype] [Android] Prototype an autoinit#949
Draft
FranAguilera wants to merge 1 commit intomainfrom
Draft
Conversation
FranAguilera
force-pushed
the
franjam/prototype-auto-init
branch
4 times, most recently
from
3caf08e to
79b0fe0
Compare
FranAguilera
force-pushed
the
franjam/prototype-auto-init
branch
from
79b0fe0 to
bed8f21
Compare
Size Comparison Report (x86_64)
|
Android Benchmark Results
Allocations
Timing
|
murki
reviewed
Apr 17, 2026
| */ | ||
| class CaptureInitializer : Initializer<Unit> { | ||
| override fun create(context: Context) { | ||
| val appContext = context.applicationContext |
Contributor
There was a problem hiding this comment.
if we do this then we don't need the ContextHolder dep, or you could do val appContext = ContextHolder.APP_CONTEXT here instead
murki
reviewed
Apr 17, 2026
|
|
||
| override fun dependencies(): List<Class<out Initializer<*>>> = listOf(ContextHolder::class.java) | ||
|
|
||
| private fun buildSessionStrategy(metadata: android.os.Bundle): io.bitdrift.capture.providers.session.SessionStrategy { |
Contributor
There was a problem hiding this comment.
if we go down this route I'd like to see us wrap all the metadata strongly-typed parsing logic inside our Configuration class so the properties stay in sync
murki
reviewed
Apr 17, 2026
| checkReleaseBuilds = true | ||
| disable.add("GradleDependency") | ||
| disable.add("AndroidGradlePluginVersion") | ||
| disable.add("EnsureInitializerMetadata") |
Contributor
There was a problem hiding this comment.
is this required? I'm hoping we don't have to ask customers to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not review, just for sharing