Skip to content

Apply BitChoiceGroup improvements (#12740) #12743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msynk wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Apply BitChoiceGroup improvements (#12740) #12743

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
951e505
apply BitChoiceGroup improvements #12740
msynk Jul 21, 2026
904f917
resolve review comments
msynk Jul 21, 2026
4dba0c3
resolve local review findings
msynk Jul 26, 2026
fa690a8
fix local review findings
msynk Jul 26, 2026
cfd9d9d
resolve review comments 2
msynk Jul 27, 2026
6ab55aa
resolve review comments 2
msynk Jul 27, 2026
8301b60
resolve review comments 3
msynk Jul 28, 2026
eddc6e1
Merge branch 'develop' of https://github.com/bitfoundation/bitplatfor…
msynk Jul 28, 2026
f5a659f
resolve review comments 4
msynk Jul 28, 2026
9c06035
resolve review comments 5
msynk Jul 28, 2026
82c8d5a
Merge branch 'develop' into 12740-blazorui-choicegroup-improvements
msynk Jul 28, 2026
91812ac
resolve review comments 6
msynk Jul 28, 2026
c209bb5
fix tests
msynk Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions src/BlazorUI/Bit.BlazorUI/Components/Inputs/ChoiceGroup/BitChoiceGroup.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,27 @@
class="@ClassBuilder.Value"
dir="@Dir?.ToString().ToLower()"
aria-label="@AriaLabel"
aria-labelledby="@GetAriaLabelledBy()">
aria-labelledby="@GetAriaLabelledBy()"
aria-required="@(Required ? "true" : null)"
aria-readonly="@(ReadOnly ? "true" : null)"
aria-disabled="@(IsEnabled ? null : "true")"
aria-orientation="@(Horizontal ? "horizontal" : "vertical")">

<label id="@_labelId"
disabled="@(IsEnabled is false)"
style="@Styles?.LabelContainer"
class="@Classes?.LabelContainer">
@if (LabelTemplate is not null)
{
@LabelTemplate
}
else if (Label.HasValue())
{
<span style="@Styles?.Label" class="bit-chg-lbl @Classes?.Label">@Label</span>
}
</label>
@if (HasLabel)
{
<label id="@_labelId"
style="@Styles?.LabelContainer"
class="@Classes?.LabelContainer">
@if (LabelTemplate is not null)
{
@LabelTemplate
}
else
{
<span style="@Styles?.Label" class="bit-chg-lbl @Classes?.Label">@Label</span>
}
</label>
}

<div id="@_optionsContainerId" style="@Styles?.Container" class="bit-chg-cnt @Classes?.Container">
@if (Options is not null || ChildContent is not null)
Expand Down
Loading
Loading