facebook/Makefile.am: add generated files to BUILT_SOURCES#217
Open
trofi wants to merge 1 commit intobitlbee:masterfrom
Open
facebook/Makefile.am: add generated files to BUILT_SOURCES#217trofi wants to merge 1 commit intobitlbee:masterfrom
trofi wants to merge 1 commit intobitlbee:masterfrom
Conversation
Without the change there is no giarantee that facebook-marshal.h
gets built before it's dependencies. On `make-4.4` `--shuffle` is
able to catch missing dependency as:
$ make --shuffle
CC facebook_la-facebook-mqtt.lo
facebook-mqtt.c:23:10: fatal error: facebook-marshal.h: No such file or directory
23 | #include "facebook-marshal.h"
| ^~~~~~~~~~~~~~~~~~~~
Automake's BUILT_SOURCES builds all sources before first object file.
The change pulls it there.
Before the change 1-2 builds triggered `make --shuffle` failure.
After the change 20 sequential rebuilds succeeded without failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change there is no giarantee that facebook-marshal.h gets built before it's dependencies. On
make-4.4--shuffleis able to catch missing dependency as:Automake's BUILT_SOURCES builds all sources before first object file. The change pulls it there.
Before the change 1-2 builds triggered
make --shufflefailure. After the change 20 sequential rebuilds succeeded without failures.