Make ziputil v2 the default (and only) ZIP extractor - #32
Open
godrei wants to merge 2 commits into
Open
Conversation
Remove the BITRISE_STEP_PULL_ARTIFACT_USE_ZIP_V2 feature flag and the legacy `unzip` CLI extraction path. ZIP archives are now always extracted in-process via ziputil.UnZip. The `tar` extraction path (legacy deploy-to-bitrise-io 2.1.2/2.1.3 support) is left on the CLI and is unchanged.
Previous steps in this CI workflow created uncommitted file changes (e.g. a code formatter, linter, or code generator). This commit captures those changes. https://github.com/bitrise-steplib/bitrise-step-autofix-ci Modified files: - README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the ziputil v2 integration (#31), which added pure-Go ZIP extraction behind the
BITRISE_STEP_PULL_ARTIFACT_USE_ZIP_V2feature flag. This PR flips it to always-on and removes the legacy path:BITRISE_STEP_PULL_ARTIFACT_USE_ZIP_V2env flag and theUseZipV2field/constructor param.unzip -oCLI branch. ZIP archives are now always extracted in-process viaziputil.UnZip.Out of scope
The
tarextraction path (legacy deploy-to-bitrise-io 2.1.2/2.1.3 support) is left on thetarCLI and is unchanged. ziputil is ZIP-only by design, so removing that shell-out would need a separate approach and is deferred.Testing
go build ./...,go vet ./..., and unit tests pass.bitrise.ymlvalidates.