Remove v1 go-utils / go-steputils dependencies - #116
Open
pgyula wants to merge 1 commit into
Open
Conversation
Move all go-utils and go-steputils usage to their v2 APIs, with dependencies (EnvRepository, Logger, FileManager, PathChecker, PathModifier, ruby.CommandFactory/Environment) injected explicitly instead of relying on package-level v1 functions. Gemfile.lock version parsing had no v2 equivalent upstream, so that logic is ported locally in gemlockfile.go. go-utils/v2 is bumped to alpha.36 to get FilterPaths/SortPathsByComponents/fileutil, which pulls in Go 1.21 as a build requirement. go-xcode stays on v1 (out of scope, tracked separately); a small adapter bridges its v1-typed path filters to the v2 filter signature so the step doesn't need to import v1 go-utils just for that.
benbitrise
approved these changes
Jul 31, 2026
benbitrise
left a comment
benbitrise
left a comment
There was a problem hiding this comment.
Ideally the gemlockfile.go string parsing stuff would have some tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gemlockfile.go.go-utils/v2to alpha.36 (needed forFilterPaths/SortPathsByComponents/fileutil), which pulls in Go 1.21 as a build requirement.go-xcodestays on v1 (out of scope, Milestone 5) — a small adapter bridges its v1-typed path filters to the v2 filter signature.After this change,
go.modno longer requires v1go-utils/go-steputilsdirectly. v1go-utilsremains only as an indirect dependency pulled in transitively bygo-xcode.Test plan
go build ./...go vet ./...gofmt -l .go test ./...(all existing unit tests pass unmodified)bitrise.ymlsample/e2e) runs on CI