Route zero-length files to single-shot upload - #264
Open
lpusok wants to merge 1 commit into
Open
Conversation
A zero-byte file has no valid multipart layout: ceil(0/partSize) is 0 parts,
but the backend still issues one part URL, so the part-count check rejected
it ("part_urls count (1) does not match expected (0)"). Send empty files
through the single-shot path (which already handles empty bodies) even when
multipart upload is enabled.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tothszabi
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A zero-byte file fails in multipart upload mode with:
ceil(0 / partSize)is 0 expected parts, but the backend (correctly) hands back 1 part URL, so the part-count check rejects it. Non-empty files are unaffected (even 1 byte ceils to 1 part).Fix
Route empty files through the single-shot path — which already handles empty bodies (
nilrequest body,Content-Length: 0) — even when multipart upload is enabled. A zero-byte file has no valid multipart part layout, so single-shot is the correct mechanism.Test plan
go build ./...passes.🤖 Generated with Claude Code