Migrate ziputil from v1 to v2 - #265
Draft
godrei wants to merge 1 commit into
Draft
Conversation
Swap go-utils v1 ziputil (which shelled out to /usr/bin/zip) for the pure-Go go-utils/v2 ziputil ZipManager. A ZipManager is constructed in main and passed into collectFilesToDeploy and the pipeline-intermediate collector. Bumping go-utils/v2 also re-vendors env, fileutil and pathutil. Add integration tests for the collectFilesToDeploy compress path that run against a real ZipManager, covering symlink storage and archive contents.
godrei
force-pushed
the
migrate-ziputil-to-v2
branch
from
July 3, 2026 13:01
6a0602b to
2b7f418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates this step from the go-utils v1
ziputilpackage to the pure-Go v2ziputil.ZipManager.main.goconstructs aZipManagerand passes it intocollectFilesToDeployand the pipeline-intermediateCollector(replacing the package-levelziputil.ZipDir).go-utils/v2, which also re-vendorsenv,fileutil, andpathutil.collectFilesToDeploycompress path that run against a realZipManager, covering symlink storage and archive contents.Why it matters
v1 shelled out to
/usr/bin/zip -rTy//usr/bin/unzip. v2 reimplements zipping in Go (archive/zip) with its own symlink, permission, mtime, and zip-slip handling. The only production path this step exercises isZipDirwithisContentOnly=true.Draft: blocked on the library
go.modpins go-utils/v2 to a pseudo-version off an unmerged branch:v2.0.0-alpha.36.0.20260612135825-fa80291d0871Before this can leave draft:
alpha.NNtag.go.modto that tag and re-vendor.Testing
go test ./...green (thetestpackage'sTest_ParseXctest3Resultsis a pre-existing local-timezone artifact; passes underTZ=UTCas CI runs it).ciworkflow zips real IPA/APK dirs and.xcresultintermediates end-to-end, which is the real check that the Go reimplementation matches the old/usr/bin/zipoutput.