Skip to content

fix(leios): support prototype vote wire format - #1877

Merged
wolf31o2 merged 1 commit into
mainfrom
fix/leios-prototype-votes-2821
Jul 14, 2026
Merged

fix(leios): support prototype vote wire format#1877
wolf31o2 merged 1 commit into
mainfrom
fix/leios-prototype-votes-2821

Conversation

@wolf31o2

@wolf31o2 wolf31o2 commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Adds support for the prototype Leios vote wire format and makes it the preferred encoding. We now handle 3-element votes [announcing_rb_hash, voter_id, signature] while keeping legacy 2- and 4-element shapes.

  • New Features
    • Added LeiosPrototypeVote in ledger/common with strict UnmarshalCBOR and signature validation.
    • Extended MsgVotesOffer in protocol/leiosnotify with PrototypeVotes; encoder prefers it, decoder sets exactly one of Votes/FullVotes/PrototypeVotes.
    • Added NewMsgVotesOfferPrototype(...) and updated tests (round-trip and invalid signature cases).

Written for commit 3d94b8d. Summary will update on new commits.

Review in cubic

@wolf31o2
wolf31o2 requested a review from a team as a code owner July 14, 2026 14:42
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@wolf31o2, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8260d3c-41ec-4971-a323-c7dfea119d60

📥 Commits

Reviewing files that changed from the base of the PR and between b170eaf and 3d94b8d.

📒 Files selected for processing (4)
  • ledger/common/leios.go
  • ledger/common/leios_test.go
  • protocol/leiosnotify/messages.go
  • protocol/leiosnotify/messages_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/leios-prototype-votes-2821

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread ledger/common/leios.go
Comment thread protocol/leiosnotify/messages.go
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2
wolf31o2 force-pushed the fix/leios-prototype-votes-2821 branch from e96250e to 3d94b8d Compare July 14, 2026 14:54
@wolf31o2
wolf31o2 merged commit 5cc51ca into main Jul 14, 2026
13 checks passed
@wolf31o2
wolf31o2 deleted the fix/leios-prototype-votes-2821 branch July 14, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants