test: replace ffldb Bitcoin fixture#80
Conversation
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdded deterministic synthetic Handshake block fixtures with serialization round-trip validation. Updated pruning, interface, and white-box tests to use the shared fixture helper and removed their early skips. Removed legacy bz2 fixture-loading code. White-box corruption testing now derives the target offset from transaction locations rather than a fixed byte offset. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 5 files
You're on the cubic free plan with 9 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
Summary
Validation
go test ./...go vet ./...make buildmake lint workers=2make unit-covermake unit-racemake integration9f013c1cb7f92edf94db69fbd69daf34adf655fbSummary by cubic
Replaced the Bitcoin-based test fixture with deterministic Handshake-wire blocks for
ffldbtests, resolving the header mismatch (80-byte Bitcoin vs 236-byte Handshake). This restores the full interface, pruning, corruption, and injected failure coverage.ffldb.TstHandshakeBlocks(t)to generate deterministic Handshake blocks from mainnet genesis (no PoW).driver_test.go,interface_test.go, andwhitebox_test.goto the new helper and unskipped the related suites.TxLocto target transaction bytes reliably.database/testdata/blocks1-256.bz2and the bzip2/IO loader code.Written for commit 1d2cf7f. Summary will update on new commits.
Summary by CodeRabbit