Skip to content

fix(openvpn): use consistent pull policy variable naming - #280

Merged
wolf31o2 merged 1 commit into
mainfrom
fix/openvpn-pull-policy
Oct 29, 2025
Merged

fix(openvpn): use consistent pull policy variable naming#280
wolf31o2 merged 1 commit into
mainfrom
fix/openvpn-pull-policy

Conversation

@wolf31o2

@wolf31o2 wolf31o2 commented Oct 29, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Corrected image pull policy configuration in the deployment template to align with expected Helm values.
  • Chores

    • Updated Helm chart version to 0.8.1.

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2
wolf31o2 requested review from a team as code owners October 29, 2025 20:37
@coderabbitai

coderabbitai Bot commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Helm chart version bumped from 0.8.0 to 0.8.1, and corrected the bind container image pull policy field reference from imagePullPolicy to pullPolicy in the deployment template.

Changes

Cohort / File(s) Summary
Helm Chart Metadata
charts/openvpn/Chart.yaml
Version incremented from 0.8.0 to 0.8.1; AppVersion and all other fields remain unchanged.
Deployment Template
charts/openvpn/templates/deployment.yaml
Corrected bind container image pull policy field reference from {{ .Values.bind.image.imagePullPolicy }} to {{ .Values.bind.image.pullPolicy }}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple version bump and single-field reference correction with no logic or behavioral changes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "fix(openvpn): use consistent pull policy variable naming" directly describes the primary functional change in the pull request. The main code change involves correcting the image pull policy variable reference in the deployment template from imagePullPolicy to pullPolicy, which is exactly what the title conveys. The title is clear, concise, and specific enough for reviewers to understand the purpose of the change. The version bump in Chart.yaml is a secondary administrative change that typically accompanies such fixes and doesn't detract from the title's accuracy.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/openvpn-pull-policy

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5adefd5 and a19e9d8.

📒 Files selected for processing (2)
  • charts/openvpn/Chart.yaml (1 hunks)
  • charts/openvpn/templates/deployment.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint-test
🔇 Additional comments (2)
charts/openvpn/Chart.yaml (1)

5-5: Version bump is appropriate.

The patch version increment (0.8.0 → 0.8.1) correctly reflects a bug fix release.

charts/openvpn/templates/deployment.yaml (1)

100-100: Bind container now uses consistent pull policy naming.

The change aligns the bind container's image pull policy reference with the main openvpn container's naming pattern (line 34).


Comment @coderabbitai help to get the list of available commands and usage tips.

@wolf31o2
wolf31o2 merged commit 8437e80 into main Oct 29, 2025
6 checks passed
@wolf31o2
wolf31o2 deleted the fix/openvpn-pull-policy branch October 29, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants