Skip to content

fix(storageclasses): remove namespace from StorageClass definition - #344

Merged
verbotenj merged 1 commit into
mainfrom
fix/storage-class-helm-chart
Mar 6, 2026
Merged

fix(storageclasses): remove namespace from StorageClass definition#344
verbotenj merged 1 commit into
mainfrom
fix/storage-class-helm-chart

Conversation

@verbotenj

@verbotenj verbotenj commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Removed namespace from the StorageClass template so installs work correctly for this cluster-scoped resource. Bumped the chart to version 0.1.2.

  • Bug Fixes
    • Removed metadata.namespace from templates/storageclass.yaml (StorageClass is cluster-scoped; namespace is invalid).
    • Updated Chart.yaml version to 0.1.2.

Written for commit cbcfb86. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version to 0.1.2
    • Modified StorageClass template to remove explicit namespace field from metadata

Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
@verbotenj
verbotenj requested review from a team as code owners March 6, 2026 18:29
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef019305-481d-4017-b948-d5861fa6953c

📥 Commits

Reviewing files that changed from the base of the PR and between db56c86 and cbcfb86.

📒 Files selected for processing (2)
  • charts/storageclasses/Chart.yaml
  • charts/storageclasses/templates/storageclass.yaml
💤 Files with no reviewable changes (1)
  • charts/storageclasses/templates/storageclass.yaml

📝 Walkthrough

Walkthrough

The pull request includes two changes to the StorageClass Helm chart. The chart version is bumped from 0.1.1 to 0.1.2 in the Chart.yaml file. Additionally, the namespace field is removed from the StorageClass metadata declaration in the Helm template, which means the rendered Kubernetes manifest will no longer inject the Release namespace into the StorageClass metadata. All other template elements remain unchanged.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(storageclasses): remove namespace from StorageClass definition' accurately and specifically describes the main change: removing the namespace field from the StorageClass template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/storage-class-helm-chart

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@verbotenj
verbotenj merged commit dcefac6 into main Mar 6, 2026
7 checks passed
@verbotenj
verbotenj deleted the fix/storage-class-helm-chart branch March 6, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants