Skip to content

chore(deps): upgrade to adder 0.33.0 - #188

Merged
wolf31o2 merged 1 commit into
mainfrom
chore/adder-0.33.0
Oct 29, 2025
Merged

chore(deps): upgrade to adder 0.33.0#188
wolf31o2 merged 1 commit into
mainfrom
chore/adder-0.33.0

Conversation

@wolf31o2

@wolf31o2 wolf31o2 commented Oct 28, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated dependencies to latest compatible versions
    • Refactored internal event handling mechanisms

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2
wolf31o2 requested a review from a team as a code owner October 28, 2025 22:28
@coderabbitai

coderabbitai Bot commented Oct 28, 2025

Copy link
Copy Markdown

Walkthrough

Go module dependencies are bumped for adder and oauth2. The indexer's event handling is updated to process a different transaction event type structure in the handleEvent function.

Changes

Cohort / File(s) Summary
Dependency Updates
go.mod
adder upgraded from v0.32.6 to v0.33.0; oauth2 upgraded from v0.31.0 to v0.32.0 (indirect)
Event Type Migration
internal/indexer/indexer.go
Type assertion in handleEvent updated to consume event.TransactionEvent instead of input_chainsync.TransactionEvent

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that event.TransactionEvent provides compatible fields (particularly Produced()) compared to the previous input_chainsync.TransactionEvent
  • Confirm dependency version upgrades have no breaking changes affecting this codebase
  • Check if the event type change is isolated to this handler or requires cascading updates elsewhere

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "chore(deps): upgrade to adder 0.33.0" directly corresponds to the primary change in go.mod, where the adder dependency is upgraded from v0.32.6 to v0.33.0. The title is specific, clear, and accurately reflects a real and significant part of the changeset. While the pull request also includes a type assertion change in internal/indexer/indexer.go (likely a necessary adjustment for the new adder version), the title appropriately focuses on the main dependency upgrade, which is typical for dependency-focused pull requests. The source branch name "chore/adder-0.33.0" further confirms that the adder upgrade is the primary objective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/adder-0.33.0

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8317af2 and 9684308.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (2 hunks)
  • internal/indexer/indexer.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: go-test (1.25.x, ubuntu-latest)
  • GitHub Check: go-test (1.24.x, ubuntu-latest)
  • GitHub Check: docker (ubuntu-latest, amd64)
  • GitHub Check: lint
  • GitHub Check: Analyze (go)
🔇 Additional comments (3)
go.mod (2)

106-106: Indirect oauth2 dependency upgraded.

The oauth2 upgrade from v0.31.0 to v0.32.0 is an indirect dependency, likely pulled in by the adder upgrade.


14-14: v0.33.0 verified: tag exists with proper breaking change handling, no security advisories found.

v0.33.0 exists as a GitHub tag, though it's not yet published as a formal release (latest published release remains v0.32.6). The breaking change is confirmed and properly handled: TransactionEvent has moved from the input_chainsync package to the event package, and the code at internal/indexer/indexer.go:247 has been correctly updated to reflect this. No security advisories were found. The upgrade is safe to proceed with.

internal/indexer/indexer.go (1)

247-247: Type change verified - no issues found.

All references to the old input_chainsync.TransactionEvent type have been successfully replaced with event.TransactionEvent. The code at line 247-248 correctly type-asserts the payload and immediately calls the Transaction.Produced() method, confirming the new type supports the required operations. The import and go.mod dependency (v0.33.0) are correctly configured.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wolf31o2
wolf31o2 merged commit 3653ebc into main Oct 29, 2025
10 checks passed
@wolf31o2
wolf31o2 deleted the chore/adder-0.33.0 branch October 29, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants