fix(desktop): page reconnect replay windows#1105
Open
tlongwell-block wants to merge 1 commit into
Open
Conversation
tlongwell-block
force-pushed
the
max/reconnect-replay-unbounded
branch
from
1f303ab to
b6b1328
Compare
tlongwell-block
changed the title
tlongwell-block
force-pushed
the
max/reconnect-replay-unbounded
branch
from
b6b1328 to
1abb7c4
Compare
Co-authored-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>
tlongwell-block
force-pushed
the
max/reconnect-replay-unbounded
branch
from
1abb7c4 to
64b8960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[lastSeen-skew, now]window is owned entirely by 500-event history pagesVerification
bin/pnpm --dir desktop test -- src/shared/api/relayReconnectReplay.test.mjsbin/pnpm --dir desktop checkbin/pnpm --dir desktop typecheckbin/pnpm --dir desktop build && bin/pnpm --dir desktop exec playwright test --project=smoke tests/e2e/relay-reconnect.spec.ts(4/4 passed)