Polish desktop sidebar navigation#1107
Open
thomaspblock wants to merge 6 commits into
Open
Conversation
Show unread message counts in channel badges and let the sidebar footer participate in normal layout so the scroll area ends cleanly above it.
Contain sidebar and top chrome wheel gestures so macOS rubber-band scrolling does not move the app shell, while keeping the sidebar scrollbar visible only during hover.
This follow-up tightens the left sidebar and profile menu details from this branch: - remove the channel/forum search icon from section headers so create is the only header action - use the same plain plus icon for Direct Messages that Channels uses - keep plus buttons hidden until the section is hovered or focused, matching the collapse arrow behavior - make the collapse arrow and plus appear together on section hover without the arrow shifting as it fades in - center profile/workspace emoji vertically in the profile menu and avoid clipping taller native emoji glyphs Together with the earlier branch work, this keeps the sidebar cleaner, prevents rubber-band scrolling in the sidebar chrome, makes unread/channel controls easier to scan, and smooths out the profile menu alignment.
# Conflicts: # desktop/src/features/channels/useUnreadChannels.ts # desktop/src/features/sidebar/ui/AppSidebar.tsx
The sidebar no longer renders the browse/search icon button, so e2e tests that opened the channel browser by clicking `browse-channels` now use the keyboard shortcut via a shared `openChannelBrowser` helper. Drops the obsolete button-specific test.
Update the sidebar smoke expectations after removing the Agents counter, and make the channel browser shortcut helper wait for the app shell before dispatching the shortcut.
thomaspblock
force-pushed
the
left-side-nav
branch
from
d0e2368 to
9ef5ecb
Compare
Collaborator
Author
leftside-nav-hardening.mp4 |
Collaborator
Author
|
Hardening the left side navigation and making sure it's not that jumpy and elastic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refines the desktop left sidebar and global top chrome with several UI and interaction fixes.
+, and the+and collapse chevron now reveal together on hover without the chevron shifting position.unreadChannelCounts.tsto stay within file-size limits.Test plan
+and chevron together, chevron stays put+; channel section search icon removed