cli: read Hive aggregate subnet env - #1053
Merged
Merged
Conversation
Contributor
Author
|
Status: ready for review. I traced the zeam-owned Hive interop issue to aggregator subnet selection: Hive sets Validation so far:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HIVE_AGGREGATE_SUBNET_IDSas a startup fallback for aggregator subnet selection--aggregate-subnet-idsbehavior and validation unchangedHive context
Suite: https://hive.leanroadmap.org/suite.html?suiteid=1784586818-a3eb27685f4418cb92cbcec02266f5f5.json&suitename=client-interop&client=zeam_devnet5
The client-interop simulator sets
HIVE_AGGREGATE_SUBNET_IDSfor multi-subnet aggregators, and gean/grandine forward that value as--aggregate-subnet-ids. The zeam Hive wrapper currently only forwards--is-aggregator, which leaves zeam aggregators subscribed to their local validator subnets instead of all assigned aggregate subnets. This makes zeam miss cross-subnet attestation traffic in the failing interop topologies.Reading the env var in zeam keeps the existing CLI flag as the operator-visible override while making the devnet5 Hive client behave with the simulator's aggregator assignment contract.
Validation
zig fmt --check pkgs/cli/src/node.ziggit diff --check/home/node/.openclaw/workspace/.tools/zig-0.16.0/zig build test --summary allwas started and reached/passed several lightweight package test groups, but the local container cannot complete the repo test target becauserustupis not installed (failed to spawn ... rustup: FileNotFound).Note: I used Zig 0.16.0 from
/home/node/.openclaw/workspace/.tools/zig-0.16.0/zig; the default/usr/local/bin/zigis 0.15.2 and cannot load this checkout's dependencies.