Skip to content

Fix[mqb]: idempotent restore state - #1190

Merged
dorjesinpo merged 3 commits into
mainfrom
fix/restore-state-race
Apr 7, 2026
Merged

Fix[mqb]: idempotent restore state#1190
dorjesinpo merged 3 commits into
mainfrom
fix/restore-state-race

Conversation

@dorjesinpo

@dorjesinpo dorjesinpo commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

If openQueue is received in between partition becoming active and node becoming available, a new primary may end up keeping remote queue.

Solution: do not open/reopen queues until node is both availalble and partition is active.

Making Queue::convertToLocal idempotent. Making restoreStateCluster independent of the order k_ANY_PARTITION_ID or N.

@dorjesinpo
dorjesinpo requested a review from a team as a code owner March 12, 2026 19:35
@dorjesinpo dorjesinpo changed the title idempotent restore state Fix[mqb]: idempotent restore state Mar 12, 2026
@dorjesinpo

dorjesinpo commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator Author

mqbc::StorageManager::do_replicaStateResponse segfault

@dorjesinpo
dorjesinpo requested review from kaikulimu March 12, 2026 21:08
@dorjesinpo dorjesinpo assigned kaikulimu and unassigned kaikulimu Mar 12, 2026
kaikulimu
kaikulimu requested changes Mar 18, 2026
View reviewed changes
Comment thread src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.h Outdated
Comment thread src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Outdated
Comment thread src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Outdated
Comment thread src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Outdated
@dorjesinpo
dorjesinpo force-pushed the fix/restore-state-race branch 3 times, most recently from e9af558 to fd26959 Compare March 19, 2026 19:21
kaikulimu
kaikulimu reviewed Mar 19, 2026
View reviewed changes

@kaikulimu kaikulimu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but ITs look bad.

@kaikulimu

kaikulimu commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Can you rebase to main branch? #1060 which causes IT failures has been rolled back.

@dorjesinpo dorjesinpo assigned dorjesinpo and unassigned kaikulimu Mar 24, 2026
@dorjesinpo
dorjesinpo force-pushed the fix/restore-state-race branch from fd26959 to 5e0d7db Compare April 2, 2026 20:13
@dorjesinpo
idempotent restore state
21ccff0 
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
@dorjesinpo
dorjesinpo force-pushed the fix/restore-state-race branch from 5e0d7db to 95e3923 Compare April 6, 2026 16:07
@dorjesinpo
undo activeAvailablePrimaryPartition
0466d52 
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
@dorjesinpo
dorjesinpo force-pushed the fix/restore-state-race branch from 95e3923 to 0466d52 Compare April 6, 2026 16:09
@dorjesinpo dorjesinpo mentioned this pull request Apr 6, 2026
Open
@dorjesinpo
registerQueueReplica unconditionally
b62f133 
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
@dorjesinpo dorjesinpo assigned kaikulimu and unassigned dorjesinpo Apr 7, 2026
kaikulimu
kaikulimu approved these changes Apr 7, 2026
View reviewed changes

@kaikulimu kaikulimu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorjesinpo
dorjesinpo merged commit bcb088a into main Apr 7, 2026
45 of 49 checks passed
@dorjesinpo
dorjesinpo deleted the fix/restore-state-race branch April 7, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikulimu kaikulimu kaikulimu approved these changes

Assignees

@kaikulimu kaikulimu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dorjesinpo @kaikulimu