Skip to content

Feat[MQBC]: print protocol message last - #1196

Merged
678098 merged 1 commit into
bloomberg:mainfrom
678098:260316_better_logs_on_cluster_send_failure
Mar 30, 2026
Merged

Feat[MQBC]: print protocol message last#1196
678098 merged 1 commit into
bloomberg:mainfrom
678098:260316_better_logs_on_cluster_send_failure

Conversation

@678098

@678098 678098 commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

In some places, we have to log messages and return codes. However, messages might be large, and we might lose return codes due to logs truncation.
Reorder the order of logged fields to log short items first, message last.

@678098
678098 requested a review from a team as a code owner March 16, 2026 16:51
@678098
678098 force-pushed the 260316_better_logs_on_cluster_send_failure branch 2 times, most recently from 609b75c to 8c854a3 Compare March 16, 2026 16:57
@678098 678098 changed the title Feat[MQBC]: print rc/destination before printing a long message Feat[MQBC]: print protocol message last Mar 16, 2026
@678098
678098 requested a review from chrisbeard March 16, 2026 17:04
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
678098 force-pushed the 260316_better_logs_on_cluster_send_failure branch from 8c854a3 to dc61a39 Compare March 27, 2026 20:30
@678098
678098 requested review from dorjesinpo and removed request for chrisbeard March 27, 2026 20:38
@678098 678098 assigned dorjesinpo and unassigned chrisbeard Mar 27, 2026
@678098
678098 merged commit a99ce85 into bloomberg:main Mar 30, 2026
45 checks passed
@678098
678098 deleted the 260316_better_logs_on_cluster_send_failure branch March 30, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants