Skip to content

MIsc[build-ubuntu.yaml]: Remove default value if required #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaikulimu merged 2 commits into from
Mar 19, 2026
Merged

MIsc[build-ubuntu.yaml]: Remove default value if required #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41613d
build-ubuntu.yaml: Remove default value if required
kaikulimu Mar 19, 2026
c949cd6
Misc[manual.yaml]: Specify C++ standard
kaikulimu Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/workflows/build-ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@ on:
description: "Whether to save the build as artifacts"
required: true
type: boolean
default: true
run_unit_tests:
description: "Whether to run unit tests. Can only be set to true if `all.t` is one of the build targets"
required: true
type: boolean
default: false
name:
description: "Name of the workflow run, used for artifacts"
required: false
Expand All @@ -36,7 +34,6 @@ on:
description: "What C++ Standard to build with. [cpp03, cpp11, cpp14, cpp17, cpp20, cpp23]"
required: true
type: string
default: "cpp17"
outputs:
artifact_key:
description: "GH Actions Cache key associated with the built dependencies"
Expand Down Expand Up @@ -68,13 +65,13 @@ jobs:
id: get_cache_key
if: inputs.save_build_as_artifacts == true # Variable type is boolean, thus no quotes
# When restoring from cache fails, it searches for other keys to fall back to.
# If the given key is a prefix of another key, it will be used.
# E.g. "...-all" can fallback to "...-all.t"
# If the given key is a prefix of another key, it will be used.
# E.g. "...-all" can fallback to "...-all.t"
# Thus do not put the target at the end of the key.
run: |
COMMIT_SHA=$(git rev-parse HEAD)
echo "cache_key=cache-${{ inputs.cxx_standard }}-${{ inputs.target }}-${COMMIT_SHA}" >> $GITHUB_OUTPUT
echo "artifact_key=${{ inputs.name }}-${{ inputs.target }}-${COMMIT_SHA}" >> $GITHUB_OUTPUT
COMMIT_SHA=$(git rev-parse HEAD)
echo "cache_key=cache-${{ inputs.cxx_standard }}-${{ inputs.target }}-${COMMIT_SHA}" >> $GITHUB_OUTPUT
echo "artifact_key=${{ inputs.name }}-${{ inputs.target }}-${COMMIT_SHA}" >> $GITHUB_OUTPUT
- uses: actions/cache/restore@v4
id: build-cache-restore-step
if: inputs.save_build_as_artifacts == true # Variable type is boolean, thus no quotes
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/manual.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ on:
workflow_dispatch:
inputs:
ref1:
description: 'Branch name, tag, or commit SHA #1'
description: "Branch name, tag, or commit SHA #1"
required: true
ref2:
description: 'Branch name, tag, or commit SHA #2'
description: "Branch name, tag, or commit SHA #2"
required: true

# The ref parameter is flexible and can accept:
Expand All @@ -38,6 +38,7 @@ jobs:
target: "bmqbrkr bmqtool"
save_build_as_artifacts: true
run_unit_tests: false
cxx_standard: cpp17

build2:
name: "Build ref ${{ github.event.inputs.ref2 }}"
Expand All @@ -49,6 +50,7 @@ jobs:
target: "bmqbrkr bmqtool"
save_build_as_artifacts: true
run_unit_tests: false
cxx_standard: cpp17

integration_tests_ubuntu_upgrade_version:
name: Test 7-node cluster upgrade [${{ matrix.cluster }}/${{ matrix.mode }}/${{ matrix.consistency }}]
Expand All @@ -63,7 +65,7 @@ jobs:
- build1
- build2
env:
RUN_UID: ${{ matrix.cluster }}_${{ matrix.mode }}_${{ matrix.consistency }}
RUN_UID: ${{ matrix.cluster }}_${{ matrix.mode }}_${{ matrix.consistency }}
steps:
- name: Checkout ITs repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -140,7 +142,6 @@ jobs:
path: ${{ github.workspace }}/repoit/src/integration-tests/failure-logs
retention-days: 5


integration_tests_ubuntu_two_versions_in_cluster:
name: IT [${{ matrix.cluster }}/${{ matrix.mode }}/${{ matrix.consistency }}]
strategy:
Expand All @@ -154,7 +155,7 @@ jobs:
- build1
- build2
env:
RUN_UID: ${{ matrix.cluster }}_${{ matrix.mode }}_${{ matrix.consistency }}
RUN_UID: ${{ matrix.cluster }}_${{ matrix.mode }}_${{ matrix.consistency }}
steps:
- name: Checkout ITs repo
uses: actions/checkout@v4
Expand Down
Loading