Fix mismatched function type in definition - #1208
Merged
Merged
Conversation
pniedzielski
previously approved these changes
Mar 19, 2026
678098
reviewed
Mar 19, 2026
|
|
||
| void AuthenticationContext::onReauthenticateErrorOrTimeout( | ||
| int errorCode, | ||
| const int errorCode, |
Collaborator
There was a problem hiding this comment.
Do we need to add const-specification for basic arithmetic type?
Collaborator
There was a problem hiding this comment.
I think we should change the declaration in header to remove const
Collaborator
Author
There was a problem hiding this comment.
Not really, this is just matching it with what's in the header file. We can just change the type of this to int as well.
Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
678098
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing some linker issues on Solaris.