Fix default allocator usage on Solaris in mqbs_filestoreprotocolutil test - #1209
Merged
Conversation
…test Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
pniedzielski
approved these changes
Mar 20, 2026
pniedzielski
left a comment
pniedzielski
left a comment
Collaborator
There was a problem hiding this comment.
The change looks fine, only the explicit construction of a value_type with an allocator argument and the subsequent .inserts are the relevant part.
Is this a bug in bsl::make_pair on Solaris, a bug in the compiler?
Collaborator
Author
|
Not really a bug in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple default allocator calls were occurring due to a difference in behavior with
bsl::make_pairon Solaris, meaning somebsl::stringobjects were being copied with the default allocator and duringOrderedMapinsertion due to thevalue_typebeing inferred asbsl::pair<K, V>instead of the correct typebsl::pair<const K, V>. The issue does not occur on Linux because these values are move constructed instead and that correctly chooses the right allocator.