Skip to content

Fix[mqb]: send UNAVAILABLE advisory last #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorjesinpo merged 1 commit into from
Mar 21, 2026
Merged

Fix[mqb]: send UNAVAILABLE advisory last #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/groups/mqb/mqbblp/mqbblp_cluster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,16 @@ void Cluster::continueShutdownDispatched(

d_clusterOrchestrator.queueHelper().processShutdownEvent();

// Make sure all partitions done sending last sync points.
// Synchronize with all Queue Dispatcher threads
bslmt::Latch latch(1);
dispatcher()->executeOnAllQueues(
mqbi::Dispatcher::VoidFunctor(), // empty
mqbi::DispatcherClientType::e_QUEUE,
bdlf::BindUtil::bindS(d_allocator_p, &bslmt::Latch::arrive, &latch));

latch.wait();

// Notify peers before going down. This should be the last message sent
// out.

Expand All @@ -689,15 +699,8 @@ void Cluster::continueShutdownDispatched(
controlMsg,
d_clusterData.transportManager());

// Make sure all partitions done sending last sync points and advisories.
// Synchronize with all Queue Dispatcher threads
bslmt::Latch latch(1);
dispatcher()->executeOnAllQueues(
mqbi::Dispatcher::VoidFunctor(), // empty
mqbi::DispatcherClientType::e_QUEUE,
bdlf::BindUtil::bindS(d_allocator_p, &bslmt::Latch::arrive, &latch));

latch.wait();
BALL_LOG_INFO << "Cluster: [name: '" << name()
<< "'] done waiting and now will close the channels";

// Close all channels of the associated cluster: when broadcasting the
// state change, the leader, in response, will potentially elect new
Expand Down
Loading