Fix[MQB]: make processingTimeStart a local variable - #1220
Merged
678098 merged 1 commit intoMar 26, 2026
Conversation
The current implementation has thread-unsafe read/write of the processingTimeStart field of DispatcherEvent, if the event is shared. This happens when we call executeOnAllQueues. The solution is to keep a local copy of processing time start. Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260325_fix_TSAN_processingTimeStart
branch
from
March 25, 2026 21:53
e34df7b to
37e32fe
Compare
waldgange
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation has thread-unsafe read/write of the
processingTimeStartfield ofDispatcherEvent, if the event is shared. This happens when we callexecuteOnAllQueues.The solution is to keep a local copy of processing time start.
east2 20:19:08.172 (139895763064512) INFO blazingmq.tsk.bmqbrkr.stderr bmqproc.py:129 Previous read of size 8 at 0x7f8b87c8f068 by thread T12:east2 20:19:08.173 (139895763064512) INFO blazingmq.tsk.bmqbrkr.stderr bmqproc.py:129 #0 BloombergLP::mqbi::DispatcherEvent::processingStartTime() const /blazingmq/src/groups/mqb/mqbi/mqbi_dispatcher.h:1656:12 (bmqbrkr.tsk+0x265fa70) (BuildId: 83595e75e3012fdf455a3917c2adda78e6ca04d1)