[Do not merge]Review Support TLS listeners - #1223
Closed
678098 wants to merge 1 commit into
Closed
Conversation
Added ===== - TLS configuration in broker config - Helper script for generating test certs and CAs - TLS options for NtcChannel - Loading certificates and authority data specified from bmqbrkrcfg.json - SessionOptions to bmq package for configuring client sessions - --tls-authority and --tls-version options to bmqtool to configure session options - Client sessions will now require broker TLS sessions when TLS protocol versions are specified - Create CertificateStore component for bmqio - Integration tests for TLS Changed ======= - Update ntf-core and bde dependencies Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net> Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
commented
Mar 26, 2026
|
|
||
| # 'sim_cpp11_features.pl' backups | ||
| *.bak | ||
| *.bak |
Collaborator
Author
There was a problem hiding this comment.
Might be moved to another PR to simplify
| class TcpInterfaceConfigValidatorTest : public ::testing::Test {}; | ||
|
|
||
| BMQTST_TEST_F(TcpInterfaceConfigValidatorTest, breathingTest) | ||
| TEST_F(TcpInterfaceConfigValidatorTest, breathingTest) |
Collaborator
Author
There was a problem hiding this comment.
Is it worth supporting both GTEST/non-GTEST UTs?
I can see two problems with GTEST usage:
- This is an extra dependency that we can avoid. Currently we have to build it for sanitizers that increases its build time. Also most of the tests are written without GTEST, so converting GTEST to native tests format is a low-effort work. Not sure about mocks though.
- Each time GTEST UT fails, we have a UT number to debug. However, this number is not mentioned anywhere in UT sources, the numbers are assigned automatically in the same order as we declare these test functions. This is not convenient.
| libfl-dev \ | ||
| libbenchmark-dev \ | ||
| libgmock-dev \ | ||
| libgtest-dev \ |
Collaborator
Author
There was a problem hiding this comment.
Have a comment about gtest below, would rather not add an extra dependency if not really necessary.
This should also reduce the number of changes in the PR.
| # :: Optionally install prerequisites ::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| REQ_PKGS=(cmake flex bison google-benchmark googletest ninja pkg-config zlib) | ||
| REQ_PKGS=(cmake flex bison google-benchmark googletest lz4 ninja openssl pkg-config zlib zstd) |
Collaborator
Author
There was a problem hiding this comment.
We can update ntf-core build in a separate PR so it does not require lz4 and zstd for now
| ;; | ||
| *) | ||
| echo "Unrecognized/missing codegen target" >&2 | ||
| usage |
Collaborator
Author
There was a problem hiding this comment.
The changes in this file might be moved to a separate PR to simplify this PR and be merged faster
| // '#include'd in the original header. | ||
| // | ||
| // Generated on Wed Jun 18 14:44:06 2025 | ||
| // Generated on Wed Mar 25 20:05:02 2026 |
Collaborator
Author
There was a problem hiding this comment.
This file might be removed from diff
| # define COMPILING_BMQU_OPERATIONCHAIN_H | ||
| # include <bmqu_operationchain_cpp03.h> | ||
| #undef COMPILING_BMQU_OPERATIONCHAIN_H | ||
| # undef COMPILING_BMQU_OPERATIONCHAIN_H |
Collaborator
Author
There was a problem hiding this comment.
The file might be removed from diff
| // Automatically generated file. **DO NOT EDIT** | ||
|
|
||
| // Generated on Wed Jun 18 14:44:06 2025 | ||
| // Generated on Wed Mar 25 20:05:02 2026 |
Collaborator
Author
There was a problem hiding this comment.
The file might be removed from diff
| // '#include'd in the original header. | ||
| // | ||
| // Generated on Wed Jun 18 14:44:06 2025 | ||
| // Generated on Wed Mar 25 20:05:02 2026 |
Collaborator
Author
There was a problem hiding this comment.
The file might be removed from diff
| fsm_cluster, | ||
| ) | ||
| # Load the fixtures defined in the BlazingMQ support library | ||
| pytest_plugins = "blazingmq.dev.it.fixtures" |
Collaborator
Author
There was a problem hiding this comment.
Does it remove pylint warnings?
This might be moved to another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.