test: blocking confirm - #1224
Merged
Merged
Conversation
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/fix-flaky-tests
branch
from
March 27, 2026 15:26
e8daeb4 to
3585061
Compare
hallfox
approved these changes
Mar 27, 2026
jll63
reviewed
Mar 27, 2026
|
|
||
| # need to make sure confirm has made it to the primary since this is a | ||
| # non-blocking op. | ||
| # Must make different confgiuration, change maxUnconfirmedMessages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests rely on CONFIRM taking effect but not synchronizing in any way (CONFIRM is async)
Suggesting a synchronization by making blocking configure call on the same queue.