Fix[mqb]: Buffer and process advisories by Cluster - #1225
Merged
Conversation
dorjesinpo
changed the title
kaikulimu
self-requested a review
March 30, 2026 20:22
kaikulimu
requested changes
Apr 1, 2026
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/buffered-advisories
branch
from
April 2, 2026 20:22
5f0e063 to
fb0492f
Compare
kaikulimu
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffered advisories should have the same effect as a real ones. In particualr, should result in the same flow ending with calling observers and
restoreStateCluster.Suggesting making
ClusterOrchestratorresponsible for buffering (better thread safety) and processing upon signal from PFSM.In PFSM/
mqbc::StorageManagerthere is some code executed when both the state isHEALEDand primary status isACTIVE. This status handling probably should be part of PFSM. At the moment, it is orthogonal.The PR attempts to track two events:
ACTIVEstatus andHEALEDstate. When both are true, we execute an idempotent code. WhenACTIVEstatus is beforeHEALEDstate, either ClusterOrchestrator buffers the advisory or PFSM updates the status and executes idempotent code later, when arriving toHEALEDstate.