Fix[mqb]: safe use of clientContext - #1231
Merged
Merged
Conversation
dorjesinpo
force-pushed
the
fix/safe-clientContext
branch
4 times, most recently
from
March 31, 2026 02:32
47c8351 to
3d7cd28
Compare
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/safe-clientContext
branch
from
March 31, 2026 15:47
3d7cd28 to
d9addb8
Compare
dorjesinpo
changed the title
hallfox
approved these changes
Mar 31, 2026
pniedzielski
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
QueueHandle::d_clientContext_spafterQueueHandle::clearClientDispatchedis possible and leads to segfault.Solution.
QueueHandle::clearClientDispatcheddoes not resetd_clientContext_sp, instead it is marked asisCleared